fix: preserve checkpoint feedback in variants and persist search journal#184
Conversation
Greptile SummaryThis PR fixes checkpoint resume reliability by addressing two specific issues: user feedback preservation during parallel variant execution and search journal persistence in later workflow phases.
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| plexe/workflow.py | Added search journal restoration to context.scratch on resume, preserved user feedback in variant workers, and persisted search journal in phase 5/6 checkpoints |
| tests/unit/workflow/test_checkpoint_resume_feedback.py | New comprehensive tests verifying user feedback preservation across variants and search journal persistence in later-phase checkpoints |
| pyproject.toml | Version bump from 1.3.5 to 1.3.6 |
Last reviewed commit: cbecdeb
There was a problem hiding this comment.
Pull request overview
This PR improves checkpoint resume reliability in later workflow phases by ensuring (1) user feedback injected during resume is preserved for all phase-4 parallel variant executions, and (2) the SearchJournal is carried forward and persisted in phase 5 and 6 checkpoints.
Changes:
- Preserve
context.scratch["_user_feedback"]when creating per-variant scratch contexts insearch_models. - Restore
SearchJournalintocontext.scratchduring checkpoint resume and persist it in phase 5 (evaluate_final) and phase 6 (package_final_model) checkpoints. - Add unit tests covering both regressions and update generated code index files.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
plexe/workflow.py |
Preserves resume feedback across variant workers; persists/restores SearchJournal through phase 5/6 checkpoints. |
tests/unit/workflow/test_checkpoint_resume_feedback.py |
Adds focused unit tests for feedback preservation across variants and journal persistence in checkpoints. |
tests/CODE_INDEX.md |
Regenerated index to include the new test module and entries. |
plexe/CODE_INDEX.md |
Regenerated index timestamp/footer update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@greptileai review again with latest changes |
This PR fixes checkpoint resume behavior by preserving injected user feedback in phase-4 variant workers and by persisting the search journal in phase 5 and 6 checkpoints. The aim is to make resume-from-checkpoint workflows reliable and consistent across later phases, including feedback-driven retries. It also includes targeted unit tests for both regressions and updates generated code indexes via project hooks.
Testing