Dev by hun756 · Pull Request #24 · pleyfy/Axrone

hun756 · 2025-10-24T15:05:14Z

No description provided.

Copilot

Pull Request Overview

This PR introduces a comprehensive WebGL2 rendering system with support for textures, shaders, materials, meshes, and batch rendering. The implementation provides a complete abstraction layer over WebGL2 with modern features including PBR materials, shader variants, and optimized batch rendering.

Key Changes

Complete WebGL2 texture system with format info, validation, and utilities
Advanced shader compilation and management with variant support and caching
Material system supporting Standard and PBR workflows with property management
Mesh/geometry system with vertex/index buffers and VAO management
Batch rendering system for optimized draw call reduction

Reviewed Changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
packages/core/src/renderer/webgl2/texture/utils.ts	Texture utility classes for format handling, WebGL constants mapping, and validation
packages/core/src/renderer/webgl2/texture/texture.ts	Core WebGL texture implementation with mipmap generation and data upload
packages/core/src/renderer/webgl2/texture/sampler.ts	Texture sampler implementation with filtering and wrapping configuration
packages/core/src/renderer/webgl2/texture/manager.ts	Texture manager for creation, caching, and loading from files
packages/core/src/renderer/webgl2/shader/utils.ts	Shader utilities for type sizes, validation, and buffer layout
packages/core/src/renderer/webgl2/shader/compiler.ts	Shader compilation with variant support and validation
packages/core/src/renderer/webgl2/shader/material.ts	Material instance with property and keyword management
packages/core/src/renderer/webgl2/shader/manager.ts	Shader manager with caching and variant handling
packages/core/src/renderer/webgl2/mesh/utils.ts	Mesh utilities for layout validation and bounds calculation
packages/core/src/renderer/webgl2/material/standard-material.ts	Unity-style standard PBR material implementation
packages/core/src/renderer/webgl2/material/pbr-material.ts	glTF 2.0 compatible PBR material implementation
packages/core/src/renderer/webgl2/batch/batch-renderer.ts	Batch renderer for optimized instanced rendering

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-24T15:06:59Z

+    }
+
+    public static generateTextureId(): string {
+        return `tex_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;


The substr method is deprecated. Use substring or slice instead.

Suggested change

return `tex_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;

return `tex_${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;

Copilot · 2025-10-24T15:06:59Z

+        }
+
+        if (TextureFormatInfo.isInteger(format)) {
+


Empty if block should either be removed or contain a TODO comment explaining why it's intentionally empty.

Suggested change

// TODO: Handle integer format compatibility if needed in future.

Copilot · 2025-10-24T15:06:59Z

+            const r = parseInt(hex.substr(0, 2), 16) / 255;
+            const g = parseInt(hex.substr(2, 2), 16) / 255;
+            const b = parseInt(hex.substr(4, 2), 16) / 255;
+            const a = hex.length === 8 ? parseInt(hex.substr(6, 2), 16) / 255 : 1;


The substr method is deprecated. Use substring or slice instead.

Suggested change

const r = parseInt(hex.substr(0, 2), 16) / 255;

const g = parseInt(hex.substr(2, 2), 16) / 255;

const b = parseInt(hex.substr(4, 2), 16) / 255;

const a = hex.length === 8 ? parseInt(hex.substr(6, 2), 16) / 255 : 1;

const r = parseInt(hex.slice(0, 2), 16) / 255;

const g = parseInt(hex.slice(2, 4), 16) / 255;

const b = parseInt(hex.slice(4, 6), 16) / 255;

const a = hex.length === 8 ? parseInt(hex.slice(6, 8), 16) / 255 : 1;

Copilot · 2025-10-24T15:07:00Z

+    }
+
+    private _generateSamplerId(): string {
+        return `sampler_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;


The substr method is deprecated. Use substring or slice instead.

Suggested change

return `sampler_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;

return `sampler_${Date.now()}_${Math.random().toString(36).substring(2, 11)}`;

Copilot · 2025-10-24T15:07:00Z

+
+        if (this.options.borderColor) {
+            const color = this.options.borderColor;
+


Empty if block should either be removed or contain a TODO comment explaining why border color configuration is not yet implemented.

Suggested change

// TODO: Border color configuration is not yet implemented.

// WebGL2 does not support sampler border color directly.

Copilot · 2025-10-24T15:07:00Z

+        }
+
+        if (this.options.lodBias !== undefined) {
+


Empty if block should either be removed or contain a TODO comment explaining why LOD bias configuration is not yet implemented.

Suggested change

// TODO: LOD bias configuration is not yet implemented.

Copilot · 2025-10-24T15:07:00Z

+        options?: { defines?: Record<string, any>; version?: string; precision?: string; }
+    ): Promise<string> {
+        return new Promise((resolve, reject) => {
+            const id = `${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;


The substr method is deprecated. Use substring or slice instead.

Suggested change

const id = `${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;

const id = `${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;

Copilot · 2025-10-24T15:07:01Z

+    }
+
+    public static generateMeshId(): string {
+        return `mesh_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;


The substr method is deprecated. Use substring or slice instead.

Suggested change

return `mesh_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;

return `mesh_${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;

Copilot · 2025-10-24T15:07:01Z

+        this.bufferFactory = createBufferFactory(gl);
+        this._usage = config.usage || BufferUsage.STATIC_DRAW;
+        this._indexType = config.indexType || IndexType.UNSIGNED_SHORT;
+        this._id = `index_buffer_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;


The substr method is deprecated. Use substring or slice instead.

Suggested change

this._id = `index_buffer_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;

this._id = `index_buffer_${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…odules

…ation

…gistration

…ra follow

… better visibility

…ontrols for dynamic offset adjustments

…ved public access and enhanced UI controls

…amping adjustments for smoother camera behavior

…ed yaw handling and rotation logic

…and enhancing fixed offset behavior

- Implemented a live editor using Monaco Editor with TypeScript support. - Created a runtime for compiling and executing scene examples with support for specific modules. - Added custom theme and configuration for the Monaco Editor. - Introduced diagnostics formatting for TypeScript compilation errors.

- Updated the main layout to a modern professional design with improved header and context bar. - Added icons to toolbar buttons for better visual representation. - Enhanced the editor and preview panels with improved loading messages and status indicators. - Implemented a resize handle for the editor panel to allow dynamic resizing. - Improved accessibility and usability with updated labels and descriptions. - Refactored CSS for a dark professional theme, including new color variables and responsive design adjustments. - Added utility classes for better styling control and consistency across components. - Introduced logic to prevent duplicate Monaco editor models.

- Created postcss.config.js to configure PostCSS with Tailwind CSS and autoprefixer. - Added tailwind.config.js to define custom theme colors, fonts, box shadows, animations, and keyframes for the project.

…dicator

…rone and Three.js

…ling

…oved rendering dynamics

…matrix adjustments

- move parent-child ownership into a dedicated Hierarchy component - keep Transform ergonomics intact while reducing runtime coupling - serialize prefab hierarchy as node links and restore it during load - refresh actor and scene coverage around the new hierarchy flow

…irst Agent-Logs-Url: https://github.com/hun756/Axrone/sessions/98ec75d3-2358-4937-9ee0-18ff24ab96d7 Co-authored-by: hun756 <56188619+hun756@users.noreply.github.com>

Scene bench

Enhance scene management, UI, and performance across components

- switch random id helpers from substr to slice - update hex color parsing to use slice with explicit ranges - clear deprecated string API usage without changing behavior

hun756 added 11 commits October 23, 2025 16:42

Refactor EventScheduler to use PriorityQueue utility

c165ed9

Refactor ParticleSystemRenderer for SOA data layout

a57b696

Add ShaderCache for managing WebGL2 shader programs

9ae9a0c

Add WebGL2 material system core classes

e3ec7bf

Add WebGL2 texture management module

b1ea9a9

Add WebGL2 framebuffer abstraction

5199d00

Add WebGL2 mesh module with interfaces and utilities

3b69e95

Add WebGL2 geometry and index buffer implementations

93839de

Add WebGL2 batch rendering system

7dcc9c4

Remove ShaderCache class from WebGL2 renderer

0f61801

Add WebGL2 shader system core implementation

2d162a0

hun756 requested a review from Copilot October 24, 2025 15:05

Copilot AI reviewed Oct 24, 2025

View reviewed changes

hun756 and others added 17 commits October 24, 2025 20:56

Update packages/core/src/renderer/webgl2/mesh/geometry.ts

a65d48c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Refactor IBindableTarget interface and update imports across WebGL2 m…

282532f

…odules

Add physics world type definitions

1768d14

Add physics primitive types and constants

a2b6076

Add physics body and shape type definitions

68b2292

Add physics types index file

18257a8

Add physics constraint and collision type definitions

a9fd999

Add ShapeManager2D for physics shape management

4f267cd

Add PhysicsWorld2D implementation

bc45815

Add circle-circle collision detection in Narrowphase2D

0b93375

Add initial IslandSolver2D implementation

5b8bb23

Add ContactManager2D for physics contact management

f92a9a8

Add 2D constraint manager implementation

cf22f25

Add BodyManager2D for physics body management

afad14c

Add DynamicAABBTree2D broadphase implementation

c5006b1

Remove readonly from IPhysicsProfiler properties

15712a4

Re-export contact manifold and point types

1d41807

hun756 and others added 29 commits April 1, 2026 16:07

feat: add color cube scene example with stable orbit camera implement…

a8ae305

…ation

refactor: Replace StableOrbitCamera with CubeSpin

d45e90c

fix: correct front face winding order to CCW in Scene class

c172764

fix: normalize vertex normals in fragment shader for accurate lighting

1f50f68

fix: enhance lighting calculations in color cube fragment shader

a71e1fb

fix: use getComponentMetadata to retrieve scriptName for component re…

ea381d8

…gistration

feat: add Follow Cube Controller with player movement and smooth came…

6151b3c

…ra follow

fix: improve grid plane shader and adjust ground plane dimensions for…

35e2dcf

… better visibility

feat: enhance CameraFollow component with zoom functionality and UI c…

cbc66be

…ontrols for dynamic offset adjustments

feat: refactor PlayerController and CameraFollow components for impro…

a01570d

…ved public access and enhanced UI controls

fix: update ground plane creation comment for clarity on mesh generation

c9b5598

feat: enhance CameraFollow component with improved lookAtOffset and d…

1822ae1

…amping adjustments for smoother camera behavior

feat: enhance PlayerController and CameraFollow components for improv…

7f0b435

…ed yaw handling and rotation logic

feat: simplify CameraFollow component by removing zoom functionality …

0ec27ac

…and enhancing fixed offset behavior

feat: remove context bar and associated styles for a cleaner UI

c866d13

feat: add Tailwind CSS configuration and PostCSS setup

f65a60c

- Created postcss.config.js to configure PostCSS with Tailwind CSS and autoprefixer. - Added tailwind.config.js to define custom theme colors, fonts, box shadows, animations, and keyframes for the project.

feat(playground): enhance auto-run toggle functionality and visual in…

698c467

…dicator

feat: add engine benchmark tool for performance comparison between Ax…

315bcd9

…rone and Three.js

feat: improve actor and component caching mechanisms with unique IDs

c77dde2

feat: add world configuration options and batch structure change hand…

ca3912b

…ling

feat: enhance scene orbit computation and camera positioning for impr…

060fbc8

…oved rendering dynamics

feat: enhance camera functionality with dynamic positioning and view …

ff394c8

…matrix adjustments

fix: sync benchmark metrics after render and restore prefab parents f…

d0feeae

…irst Agent-Logs-Url: https://github.com/hun756/Axrone/sessions/98ec75d3-2358-4937-9ee0-18ff24ab96d7 Co-authored-by: hun756 <56188619+hun756@users.noreply.github.com>

Merge pull request #2 from hun756/scene-bench

4f37bc9

Scene bench

Merge pull request #3 from hun756/runtime

05cf989

Enhance scene management, UI, and performance across components

refactor(core): replace deprecated substr usage

4965c99

- switch random id helpers from substr to slice - update hex color parsing to use slice with explicit ranges - clear deprecated string API usage without changing behavior

hun756 merged commit 3d1b91d into pleyfy:dev Apr 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev#24

Dev#24
hun756 merged 142 commits into
pleyfy:devfrom
hun756:dev

hun756 commented Oct 24, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	return `tex_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;
	return `tex_${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;


	// TODO: Handle integer format compatibility if needed in future.

	return `sampler_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;
	return `sampler_${Date.now()}_${Math.random().toString(36).substring(2, 11)}`;


		if (this.options.borderColor) {
		const color = this.options.borderColor;


	// TODO: Border color configuration is not yet implemented.
	// WebGL2 does not support sampler border color directly.

	const id = `${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;
	const id = `${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;

	return `mesh_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;
	return `mesh_${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;

	this._id = `index_buffer_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;
	this._id = `index_buffer_${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;

Conversation

hun756 commented Oct 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants