document .gitignore. Add .DS_Store to it while at it. #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
So it seems to pre-commit hook didn't like my changes to |
Collaborator
|
The pre-commit setup sorts it alphabetically, which is incorrect given that .gitignore exclusions and inclusions are order-dependent, so that should probably be taken out. (The details are in the pre-commit config file. Follow the links to the various repositories to find out what code each action runs.) |
Collaborator
Author
|
This one is ready for review @wenkokke . |
wenkokke
previously approved these changes
Jul 26, 2025
Collaborator
|
I meant after their respective inclusions, eg, the zip inclusion after the general exclusion, but that's alright, we can fix that later. |
noughtmare
pushed a commit
to noughtmare/plfa.github.io
that referenced
this pull request
Oct 24, 2025
As per title. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Wen Kokke <wenkokke@users.noreply.github.com>
peterthiemann
pushed a commit
to proglang/plfa.github.io
that referenced
this pull request
Jan 16, 2026
As per title. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Wen Kokke <wenkokke@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title.