Skip to content

links instead hrefs#32

Merged
jkralik merged 6 commits intomasterfrom
linksInsteadHrefs
Sep 16, 2019
Merged

links instead hrefs#32
jkralik merged 6 commits intomasterfrom
linksInsteadHrefs

Conversation

@jkralik
Copy link
Member

@jkralik jkralik commented Sep 13, 2019

new API allows to avoid call of multicast for update/retrieve resource.
retrieve links is possible any time by calling GetResourceLinks

@jkralik jkralik requested a review from cizmazia September 13, 2019 09:14
@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

Merging #32 into master will decrease coverage by 0.83%.
The diff coverage is 62.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   53.25%   52.42%   -0.84%     
==========================================
  Files          18       18              
  Lines        1091     1011      -80     
==========================================
- Hits          581      530      -51     
+ Misses        417      391      -26     
+ Partials       93       90       -3
Impacted Files Coverage Δ
local/client.go 50% <ø> (-3.94%) ⬇️
local/observeResource.go 4.87% <0%> (ø) ⬆️
local/device.go 73.95% <100%> (+0.81%) ⬆️
local/isSecured.go 71.42% <100%> (ø) ⬆️
local/getResourceLinks.go 56.25% <36.36%> (-19.29%) ⬇️
local/getResource.go 30.43% <37.5%> (+7.93%) ⬆️
local/disownDevice.go 52.38% <50%> (-3.18%) ⬇️
local/getDevice.go 62.5% <60%> (+0.59%) ⬆️
local/getDevices.go 63.33% <60%> (+1.17%) ⬆️
local/provisionDevice.go 69.23% <60.6%> (-1.83%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa60775...2cadb8a. Read the comment docs.

@jkralik jkralik merged commit 867fd8b into master Sep 16, 2019
@jkralik jkralik deleted the linksInsteadHrefs branch September 16, 2019 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants