helm: fix authority for mock-oauth-server

[jkralik]

No description provided.

[coderabbitai]

Walkthrough

The changes focus on refining the TLS configuration logic within the charts/plgd-hub/templates/_helpers.tpl file. Specifically, the modifications address how audience and endpoints settings are managed, especially when the mockoauthserver is enabled. This includes adjustments to the conditional logic and template string resolutions for these configurations.

Changes

File Path	Summary
charts/plgd-hub/templates/_helpers.tpl	Adjusted TLS configuration logic, particularly for audience and endpoints handling based on mockoauthserver setting. Replaced $ca with $authority in global authority configuration.

Poem

In the charts where logic dwells,
TLS now stronger, the audience tells.
Endpoints refined, with care and might,
Mock server's tune now set just right.
Authority switched, ca to new,
Plgd-hub, we trust in you! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (1)

charts/plgd-hub/templates/_helpers.tpl (1)

Line range hint 695-696: Remove redundant if block for mockoauthserver.enabled.

The configuration should adjust based on the presence of mockoauthserver without the need for this condition.

- {{- if $.Values.mockoauthserver.enabled }}
- # Configuration of audience and endpoints based on mockoauthserver presence
+ # Configuration of audience and endpoints based on mockoauthserver presence
- {{- end }}

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ad3d2c5 and f45f736.

Files selected for processing (1)

• charts/plgd-hub/templates/_helpers.tpl (3 hunks)

Additional comments not posted (1)

charts/plgd-hub/templates/_helpers.tpl (1)

655-659: Ensure $authority is set correctly based on mockoauthserver.enabled.

The logic correctly sets $authority if mockoauthserver is enabled, but it should ensure that $authority is not already defined before setting it.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f45f736 and 544e887.

Files selected for processing (1)

• charts/plgd-hub/templates/_helpers.tpl (3 hunks)

Files skipped from review as they are similar to previous changes (1)

• charts/plgd-hub/templates/_helpers.tpl

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud