resource-aggregate: add Delete call to eventstore#381
Merged
Conversation
jkralik
reviewed
Aug 5, 2021
Danielius1922
force-pushed
the
feature/delete-device
branch
from
f63edac to
afed5a1
Compare
jkralik
approved these changes
Aug 9, 2021
Danielius1922
force-pushed
the
feature/delete-device
branch
2 times, most recently
from
1837ed5 to
8d755b1
Compare
jkralik
reviewed
Aug 10, 2021
jkralik
requested changes
Aug 10, 2021
Member
jkralik
left a comment
jkralik
left a comment
There was a problem hiding this comment.
pls fix inconsistency of delete between RA and AUTH service for empty deviceIds.
jkralik
reviewed
Aug 11, 2021
Danielius1922
force-pushed
the
feature/delete-device
branch
from
815bfbd to
23d5174
Compare
jkralik
reviewed
Aug 12, 2021
jkralik
approved these changes
Aug 13, 2021
Danielius1922
force-pushed
the
feature/delete-device
branch
from
1e2b86c to
0964760
Compare
jkralik
approved these changes
Aug 16, 2021
Add Delete call to eventstore which deletes all documents with given groupIds.
Rework Delete call to enable deletion of multiple deviceIds at the same time.
Previously the implementation ran delete one-by-one by deviceID and returned a list of device ids that had at least one document deleted. However, this is not a useful output because the caller cannot use it to determine whether all documents with the deviceID were deleted, or whether documents with given ID were not deleted because no such documents existed before the call. Instead of the output from the Delete command the db should be queried again to get the current state.
Sending DeleteDevicesRequest with empty DeviceIds list is interpreted as requesting to delete all owned devices
Delete all owned devices if empty deviceIdFilter is used.
Sent the same input to ResourceAggregate and Authorization service from DeleteDevices in grpc-gw
Remove all documents for given device from eventstore when it signs off.
Danielius1922
force-pushed
the
feature/delete-device
branch
from
0964760 to
1721256
Compare
Danielius1922
force-pushed
the
feature/delete-device
branch
from
e77fb7b to
e410a5c
Compare
ondrejtomcik
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Delete call to eventstore which deletes all documents with given groupIds.