Skip to content

introduce consent screen and custom scopes in mock oauth server#569

Merged
ondrejtomcik merged 12 commits into
mainfrom
ondrejtomcik/feature/mock-oauth-with-consent-screen
Dec 11, 2021
Merged

introduce consent screen and custom scopes in mock oauth server#569
ondrejtomcik merged 12 commits into
mainfrom
ondrejtomcik/feature/mock-oauth-with-consent-screen

Conversation

@ondrejtomcik
Copy link
Copy Markdown
Member

No description provided.

@jkralik
Copy link
Copy Markdown
Member

jkralik commented Nov 25, 2021

The test fails because you pass the array as a joined string with "," so the scope is not an array as is expected by parser scopes:
https://github.com/plgd-dev/hub/blob/main/pkg/security/jwt/claims.go#L72

Comment thread test/oauth-server/service/token_test.go Outdated
Comment thread test/oauth-server/service/token_test.go Outdated
Comment thread test/oauth-server/uri/uri.go Outdated
Comment thread test/oauth-server/service/token.go
@Danielius1922 Danielius1922 force-pushed the ondrejtomcik/feature/mock-oauth-with-consent-screen branch 3 times, most recently from 6964392 to 044c7bd Compare December 7, 2021 07:39
Comment thread coap-gateway/service/refreshToken_test.go
@Danielius1922 Danielius1922 self-requested a review December 9, 2021 10:22
Comment thread test/oauth-server/service/config.go Outdated
@Danielius1922 Danielius1922 self-requested a review December 9, 2021 10:52
@Danielius1922
Copy link
Copy Markdown
Member

Danielius1922 commented Dec 9, 2021

Regarding SonarCloud analysis: I usually ignore low coverage if it's caused by negative code paths (ie error handling). However, since mock oauth is an integral part of most of our tests I would keep the coverage analysis enabled and try to keep coverage in the usual 70-80% realm (if possible), so we know it behaves as it should.

@ondrejtomcik
Copy link
Copy Markdown
Member Author

@Danielius1922 okay. I will do my homework 🙂

@ondrejtomcik ondrejtomcik force-pushed the ondrejtomcik/feature/mock-oauth-with-consent-screen branch from 5012ada to 55f672d Compare December 10, 2021 08:06
@ondrejtomcik
Copy link
Copy Markdown
Member Author

@Danielius1922 better coverage? :)

@jkralik
Copy link
Copy Markdown
Member

jkralik commented Dec 10, 2021

Please update properly MR https://github.com/plgd-dev/www/pull/35

@jkralik
Copy link
Copy Markdown
Member

jkralik commented Dec 10, 2021

@ondrejtomcik Did you look at smells (2 critical)?

@Danielius1922
Copy link
Copy Markdown
Member

@Danielius1922 better coverage? :)

Yop, great coverage! Good job.

Comment thread test/oauth-server/service/token_test.go Outdated
Comment thread test/oauth-server/test/test.go Outdated
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.6% 89.6% Coverage
0.0% 0.0% Duplication

@ondrejtomcik ondrejtomcik merged commit 6ef3eff into main Dec 11, 2021
@ondrejtomcik ondrejtomcik deleted the ondrejtomcik/feature/mock-oauth-with-consent-screen branch December 11, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants