Skip to content

certManager: support string array and string in caPool property#814

Merged
jkralik merged 3 commits into
mainfrom
jkralik/feature/capool-array
Nov 10, 2022
Merged

certManager: support string array and string in caPool property#814
jkralik merged 3 commits into
mainfrom
jkralik/feature/capool-array

Conversation

@jkralik
Copy link
Copy Markdown
Member

@jkralik jkralik commented Nov 9, 2022

No description provided.

@jkralik jkralik force-pushed the jkralik/feature/capool-array branch 2 times, most recently from f77d503 to f018ae2 Compare November 9, 2022 09:51
@jkralik jkralik requested a review from Danielius1922 November 9, 2022 11:54
Copy link
Copy Markdown
Member

@ondrejtomcik ondrejtomcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update documentation of config properties in doc. it's important for auth.caPool

Comment thread pkg/security/certManager/client/certManager_test.go
Comment thread pkg/security/certManager/client/certManager.go Outdated
Comment thread pkg/security/certManager/general/certManager_test.go Outdated
@jkralik jkralik force-pushed the jkralik/feature/capool-array branch 2 times, most recently from 38ff88b to ed7c45e Compare November 10, 2022 10:23
@jkralik jkralik force-pushed the jkralik/feature/capool-array branch 2 times, most recently from b1c9ae1 to 9138022 Compare November 10, 2022 15:54
@jkralik jkralik force-pushed the jkralik/feature/capool-array branch from 9138022 to 3007ae4 Compare November 10, 2022 15:54
@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

64.2% 64.2% Coverage
2.5% 2.5% Duplication

@jkralik jkralik merged commit 5314bbe into main Nov 10, 2022
@jkralik jkralik deleted the jkralik/feature/capool-array branch November 10, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants