Add websockets server to librespot#152
Closed
sashahilton00 wants to merge 2 commits intoplietar:masterfrom
sashahilton00:websockets
Closed
Add websockets server to librespot#152sashahilton00 wants to merge 2 commits intoplietar:masterfrom sashahilton00:websockets
sashahilton00 wants to merge 2 commits intoplietar:masterfrom
sashahilton00:websockets
Conversation
Adds web socket server. Badly coded, intended as PoC. Also updates spotify_id.rs with new methods.
Contributor
Author
|
@plietar was just thinking back to what you mentioned in the other pull request, presumably one could use websockets for the ipc that you mentioned in the other pull request? |
Owner
|
Not sure what PR you're referring to ? The volume control #148 ? Overall I think this functionality should live outside librespot. Spotifyd maybe ? I'd be happy to add infrastructure to pull the events out of librespot if needed, but the websockets API doesn't belong in here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds web socket server. Badly coded, intended as PoC. Aka. Can't Recommend A Pull (request). Also updates spotify_id.rs with new methods.
It would be good to have something like a websockets server that makes it easy for users who do not have a good grasp of rust (me)/want to integrate with librespot in a relatively easy/quick manner for whatever project they are working on. Hence this PR includes some barebones functionality that allows one to get the current activity of librespot via a websockets server running on port 3012. It would be good if someone who has a clue what they are doing could look at and rewrite it so that librespot is not hosting a websocket server in one part of the application, then starting a client in another part just to send out the messages. From there it would be possible to add things such as client side queries, proper metadata, play queues, etc.
Like I said, this code is rubbish, and should be left in a separate branch to master. As it currently stands there are a number of issues not limited to:
S.