feat: expose sub_account_name on Number resource#312
Merged
Conversation
Sub-account name is forwarded automatically via dynamic attribute on PlivoResource (response keys -> instance attrs). This commit adds: - explicit test coverage asserting number.sub_account and number.sub_account_name are set from the mock response - version bump to 4.60.2 and CHANGELOG entry Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Narayana Shanbhog Plivo (narayana-plivo)
approved these changes
May 26, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Number.sub_accountandNumber.sub_account_nameare surfaced by the SDK on rented number get/list APIs.PlivoResource's dynamic attribute mapping (self.__dict__.update(response)); this release makes the behavior part of the contract.Mirrors the parallel FNT-370 work in plivo-go#244, plivo-ruby#264, plivo-java#317, plivo-php#371, plivo-dotnet#312.
Test plan
python3 -m unittest tests.resources.test_numberspasses locally (9/9)numberGetResponse.json/numberListResponse.jsonfixtures includesub_account_name🤖 Generated with Claude Code