Support github options extra_lines/extra_lines_after_os_dependencies#292
Merged
Support github options extra_lines/extra_lines_after_os_dependencies#292
Conversation
…ies. `extra_lines` was already passed on to the test matrix, but not used. `extra_lines_after_os_dependencies` is needed for `Products.CMFPlone` to configure a locale, needed for one test.
78fa40e to
6793611
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extra_lineswas already passed on to the test matrix, but not used.extra_lines_after_os_dependenciesis needed forProducts.CMFPloneto configure a locale, needed for one test.This is needed in CMFPlone, otherwise you get a few test failures:
I use this in the CMFPlone src-layout PR, in this commit. And the try to fix it in this second commit. And that seems to help.