Skip to content

Support github options extra_lines/extra_lines_after_os_dependencies#292

Merged
gforcada merged 1 commit into2.xfrom
maurits-extra_lines_after_os_dependencies
Sep 14, 2025
Merged

Support github options extra_lines/extra_lines_after_os_dependencies#292
gforcada merged 1 commit into2.xfrom
maurits-extra_lines_after_os_dependencies

Conversation

@mauritsvanrees
Copy link
Member

extra_lines was already passed on to the test matrix, but not used. extra_lines_after_os_dependencies is needed for Products.CMFPlone to configure a locale, needed for one test.

This is needed in CMFPlone, otherwise you get a few test failures:

ValueError: Unsupported locale.
These tests need at least one of the following locales available on your system:
('en_US.ISO-8859-1', 'en_US.ISO8859-15', 'en_GB.ISO8859-15',
'de_DE@euro', 'fr_FR@euro', 'nl_NL@euro')

I use this in the CMFPlone src-layout PR, in this commit. And the try to fix it in this second commit. And that seems to help.

…ies.

`extra_lines` was already passed on to the test matrix, but not used.
`extra_lines_after_os_dependencies` is needed for `Products.CMFPlone` to configure a locale, needed for one test.
@mauritsvanrees mauritsvanrees force-pushed the maurits-extra_lines_after_os_dependencies branch from 78fa40e to 6793611 Compare September 12, 2025 20:42
Copy link
Member

@gforcada gforcada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏾

@gforcada gforcada merged commit bd6ab78 into 2.x Sep 14, 2025
1 check passed
@gforcada gforcada deleted the maurits-extra_lines_after_os_dependencies branch September 14, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants