Skip to content

fix(pat-tinymce): Ingore english language variant translations.#1506

Closed
thet wants to merge 1 commit intomasterfrom
tinymce-translations--ignore-variants
Closed

fix(pat-tinymce): Ingore english language variant translations.#1506
thet wants to merge 1 commit intomasterfrom
tinymce-translations--ignore-variants

Conversation

@thet
Copy link
Member

@thet thet commented Oct 9, 2025

For english translations, ignore country specific language varants. This fixes a probem which occured with a language variant as portal language.

TODO: verify! but I can't remember anymore.

@thet thet marked this pull request as draft October 9, 2025 22:45
@petschki
Copy link
Member

I quickly created a Classic-UI Site with en-us as portal language and TinyMCE worked well... not sure if there are some corner cases though. But this change hardens language negotiation anyways and can be merged in my opinion.

@petschki petschki force-pushed the tinymce-translations--ignore-variants branch from 9e363ae to 101f4f4 Compare March 11, 2026 16:25
@petschki

This comment was marked as outdated.

2 similar comments
@petschki

This comment was marked as outdated.

@petschki

This comment was marked as outdated.

For english translations, ignore country specific language varants.
This fixes a probem which occured with a language variant as portal
language.

TODO: verify! but I can't remember anymore.
@petschki petschki force-pushed the tinymce-translations--ignore-variants branch from 101f4f4 to 7836d7f Compare March 12, 2026 06:59
@thet
Copy link
Member Author

thet commented Mar 15, 2026

Something has changed in TinyMCE lanugage loading.
When loading the language js file a tinymce.addI18n method must already exist.
Maybe we can first initialize TinyMCE with english language and then load the translation file?
Or we use the language_url option?
Anyways, TinyMCE doesn't make it easy to not use their premium plugins.
https://www.tiny.cloud/docs/tinymce/latest/ui-localization/

@petschki
Copy link
Member

Oh yes. Free Tiny gets more and more cut in abilities. There is a hint to platejs in the bucharest sprint docs. Definitely worth a look for classic ui too.

@thet thet force-pushed the tinymce-translations--ignore-variants branch from 56fa731 to 7836d7f Compare March 16, 2026 19:41
@thet
Copy link
Member Author

thet commented Mar 16, 2026

We can already use https://github.com/patternslib/pat-tiptap
It would be nice to have that integrated in Plone.

@thet thet mentioned this pull request Mar 16, 2026
@thet
Copy link
Member Author

thet commented Mar 16, 2026

I tried to load the TinyMCE 8 languages in this PR: #1558

I think this one is obsolete. I cannot reproduce the problem either.

1 similar comment
@thet
Copy link
Member Author

thet commented Mar 19, 2026

I tried to load the TinyMCE 8 languages in this PR: #1558

I think this one is obsolete. I cannot reproduce the problem either.

@thet thet closed this Mar 19, 2026
@thet thet deleted the tinymce-translations--ignore-variants branch March 19, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants