Skip to content

Comments

Fixes #1501#1532

Merged
petschki merged 1 commit intoplone:5.4.xfrom
codeWithPunith:fix-1501-5.4
Feb 3, 2026
Merged

Fixes #1501#1532
petschki merged 1 commit intoplone:5.4.xfrom
codeWithPunith:fix-1501-5.4

Conversation

@codeWithPunith
Copy link
Contributor

@codeWithPunith codeWithPunith commented Feb 2, 2026

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

@codeWithPunith
Copy link
Contributor Author

codeWithPunith commented Feb 2, 2026

@petschki Hi , I followed the same steps i mean i didn't include .DS_Store nor did i update anything in yarn.lock but i dont know how there are 6 files that are changed where did i go wrong ?

@petschki
Copy link
Member

petschki commented Feb 2, 2026

  1. check that your fork is based on plone:5.4.x
  2. merge your PR back into plone:5.4.x you can change the PR base branch with the edit button next to the PR title above.

@codeWithPunith codeWithPunith changed the base branch from master to 5.4.x February 3, 2026 02:40
@codeWithPunith
Copy link
Contributor Author

codeWithPunith commented Feb 3, 2026

@petschki Thank you for the help.
Please let me know if any adjustments are needed. I’m also happy to help further with related work such as the select2 upgrade PR if useful.

And i wanted some guidance regarding gsoc where can i ping you

@codeWithPunith codeWithPunith changed the base branch from 5.4.x to master February 3, 2026 02:44
@codeWithPunith codeWithPunith changed the base branch from master to 5.4.x February 3, 2026 02:45
@petschki petschki merged commit 81498b4 into plone:5.4.x Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants