Skip to content

Conversation

@cekk
Copy link
Member

@cekk cekk commented Jun 16, 2018

I have this error when using the previous version:

error @plone/plone-react@0.5.0: The engine "node" is incompatible with this module. Expected version "~8.11.2".
error Found incompatible module

We could also set lts in this file, which is 8.11.3

I have this error when using the previous version:

    error @plone/plone-react@0.5.0: The engine "node" is incompatible with this module. Expected version "~8.11.2".
    error Found incompatible module

We could also set lts in this file, which is 8.11.3
@coveralls
Copy link

coveralls commented Jun 16, 2018

Coverage Status

Coverage decreased (-2.5%) to 55.167% when pulling dd8acf7 on fix-nvmrc-version into 671049e on master.

@tisto
Copy link
Member

tisto commented Jun 16, 2018

@cekk I already set LTS = 8.11.x in package.json. Does nvm automatically pick up the version in a local .nvmrc file? I think we can all agree that plone-react should run on the latest node LTS. We shouldn't be too picky with the minor version though (expect on CI, where we should pin exactly one version and always update manually to catch possible regressions).

@pnicolli
Copy link
Contributor

Yes, nvm does read the .nvmrc file if you run just nvm use inside the project, instead of writing the version number. I agree it should run on the latest LTS, the .nvmrc file could be lts as @cekk suggested, or it can be just 8 or 8.11 which is very similar to the declaration in the package.json file.
If we still want to be super precise for CI purposes, then I think we should definitely pin the .nvmrc file to the latest 8.11 so that it works if used for development.

@robgietema robgietema merged commit fa89f3a into master Jun 25, 2018
@robgietema robgietema deleted the fix-nvmrc-version branch June 25, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants