Fix AttributeError in orderObjects after deleting an object and restarting Zope#50
Conversation
|
@wesleybl thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
wesleybl
force-pushed
the
order_objects_stale_after_delete_and_restart
branch
from
e7ea1b9 to
e233bcf
Compare
|
@jenkins-plone-org please run jobs |
…estarting Zope Replace sorted() + _set_order() with an in-place sort, preserving the PersistentList.
wesleybl
force-pushed
the
order_objects_stale_after_delete_and_restart
branch
from
e233bcf to
2b9d478
Compare
|
@jenkins-plone-org please run jobs |
mauritsvanrees
left a comment
mauritsvanrees
left a comment
There was a problem hiding this comment.
I confirm the problem (in Plone 6.2 coredev). Ouch.
I confirm that the fix works. Thanks!
|
@wesleybl Could you backport this to branch 4.x please? |
3 participants
Replace
sorted()+_set_order()with an in-placesort, preserving thePersistentList.Closes plone/Products.CMFPlone#4311