Skip to content

Conversation

@ale-rt
Copy link
Member

@ale-rt ale-rt commented Apr 10, 2020

Use the zope global request if available as a fallback if the context does not have it

Fixes #17
Closes #18
Closes #20

This is based on #18 and #20, if they are merged the only commit that adds something is
559e5ee

@mister-roboto
Copy link

@ale-rt thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@ale-rt
Copy link
Member Author

ale-rt commented Apr 10, 2020

@jenkins-plone-org please run jobs

Use the zope global request if available as a fallback if the context does not have it

Fixes #17
@ale-rt ale-rt force-pushed the 17-use-global-request branch from 559e5ee to 1c29639 Compare April 11, 2020 14:44
@ale-rt
Copy link
Member Author

ale-rt commented Apr 11, 2020

@jenkins-plone-org please run jobs

@ale-rt ale-rt merged commit f378dc6 into master Apr 11, 2020
@ale-rt ale-rt deleted the 17-use-global-request branch April 11, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow plone.memoize.view to use the global request

4 participants