Skip to content

Platinum sponsors round2#247

Merged
erral merged 2 commits intomainfrom
platinum-sponsors-round2
Mar 16, 2026
Merged

Platinum sponsors round2#247
erral merged 2 commits intomainfrom
platinum-sponsors-round2

Conversation

@erral
Copy link
Member

@erral erral commented Mar 16, 2026

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

After merging the previous #246 we found that we need some minor wording changes and more margin for the footer. This Pr addresses it.

@astridjuizi

This is the home page

2026-03-16 08-08-44

This is a sponsor's page

2026-03-16 08-08-51

@erral erral requested a review from Fosten March 16, 2026 07:12
@stevepiercy
Copy link
Contributor

@astridjuizi I can't add you as a reviewer or autocomplete your username.

@erral can you discuss amongst the appropriate team whether Astrid can be added to this repo under some team or group where we can assign her as a reviewer and tag her? Perhaps Plone.org or plone/marketing-communications team?

@erral erral merged commit c5dca6d into main Mar 16, 2026
13 checks passed
@erral erral deleted the platinum-sponsors-round2 branch March 16, 2026 08:00
@erral
Copy link
Member Author

erral commented Mar 16, 2026

These are the screenshots of testing.plone.org with the said changes

Home

testing plone org_ (1)

What is Plone

testing plone org_what_is_plone

Sponsor page

testing plone org_foundation_sponsorship_sponsors_interaktiv

@Fosten @astridjuizi

@astridjuizi
Copy link

That sponsor logo size looks much much better. The text also flows nicely. The "Your Logo Here" with the dotted outline looks good and balances the current single logo, and gives a feeling of space to invite others to get their logo there. LGTM

Copy link
Contributor

@Fosten Fosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erral
Copy link
Member Author

erral commented Mar 16, 2026

Thanks, let's deploy this to plone.org and see how it behaves there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants