Fix devcontainer copier-templates mount and $HOME build warning#110
Merged
Conversation
- Use a single read-write bind of the host dev clone (~/develop/plone/src/copier-templates) into the path plonecli reads (~/.copier-templates/plone-copier-templates), replacing the broken non-existent mount and the redundant readonly mount. - Update initializeCommand to ensure the dev path exists. - Use explicit /home/node instead of undefined $HOME in Dockerfile PATH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a single read-write bind of the host dev clone (
/develop/plone/src/copier-templates) into the path plonecli reads (/.copier-templates/plone-copier-templates), replacing the broken non-existent mount and the redundant readonly mount.Update initializeCommand to ensure the dev path exists.
Use explicit /home/node instead of undefined $HOME in Dockerfile PATH.
I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
I verified there aren't any other open pull requests for the same change.
I followed the guidelines in Contributing to Plone.
I successfully ran code quality checks on my changes locally.
I successfully ran tests on my changes locally.
If needed, I added new tests for my changes.
If needed, I added documentation for my changes.
I included a change log entry in my commits.
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #