Skip to content

Ensure unlock wait after saving working copy changes in Cypress tests#8024

Merged
davisagli merged 2 commits intomainfrom
cypress-working-copy
Mar 19, 2026
Merged

Ensure unlock wait after saving working copy changes in Cypress tests#8024
davisagli merged 2 commits intomainfrom
cypress-working-copy

Conversation

@wesleybl
Copy link
Copy Markdown
Member

This fixes the error:

1) Working Copy Tests - Applying
       Basic apply operation:
     AssertionError: Timed out retrying after 4000ms: Expected to find content: 'Changes applied' but never did.
      at Context.eval (webpack://@plone/volto/./cypress/tests/workingCopy/applying.js:45:7)

See: https://github.com/plone/volto/actions/runs/23294919481/job/67739734466#step:4:212

@wesleybl wesleybl requested review from davisagli and sneridagh March 19, 2026 16:02
Copy link
Copy Markdown
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but note that there's a real race condition here too. If the save finishes before the unlock, then the actions menu does not include the options for applying or canceling the working copy.

To avoid that I'd like to add a way to unlock the item in the same transaction where it is saved, via a special header.

@davisagli davisagli merged commit b092022 into main Mar 19, 2026
78 checks passed
@davisagli davisagli deleted the cypress-working-copy branch March 19, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants