fix(google-contacts): default the Contacts channel on#225
Merged
Conversation
The single synthetic "Contacts" channel had no enabledByDefault hint, so the
client's default-channel chooser (ChannelDefaultSuggester) ran its low-value
title heuristic — whose `contacts?\b` rule exists to exclude Google's
informational "Contacts' birthdays" calendar — and silently de-selected it.
On a fresh connect of the combined Google connector this left the granted
Contacts product disabled ("Not synced") even though its scope was requested
and granted.
Set enabledByDefault: true on the channel (in both the shared
getContactsChannels export and the standalone connector's getChannels) so it
defaults on, the same explicit-hint mechanism Gmail (INBOX/SENT) and Calendar
(primary) use to override the heuristic.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a fresh connect of the combined Google connector, Google Contacts lands disabled ("Not synced") even when its scope was requested and granted — while Gmail, Calendar, and Tasks default on.
Root cause
getContactsChannels()returns a single synthetic channel titled"Contacts"with noenabledByDefaulthint. The Flutter client's default-channel chooser (ChannelDefaultSuggester) then runs its low-value title heuristic, whosecontacts?\brule exists to exclude Google's informational "Contacts' birthdays" calendar — and it also matches the real Contacts product channel, so it gets de-selected by default.(Tasks defaults on because its list title isn't low-value and its hint is
null→ the heuristic includes it.)Fix
Set
enabledByDefault: trueon the Contacts channel — the explicit connector override that forces a channel on regardless of the title heuristic, the same mechanism Gmail (INBOX/SENT) and Calendar (primary) use. Applied in bothgetContactsChannels(consumed by the combined connector) and the standalone connector'sgetChannels.No changeset: connector package, not
twister/.Testing
Confirmed on macOS: fresh connect of the combined Google connection now defaults Contacts on alongside Gmail/Calendar/Tasks.
🤖 Generated with Claude Code