Skip to content

Update ChromeNotFoundError #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayjayt merged 3 commits into from
Mar 25, 2025
+4 −5
Merged

Update ChromeNotFoundError #303

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f8c026
Update ChromeNotFoundError text
LiamConnors Mar 5, 2025
67520de
Update kaleido.py
LiamConnors Mar 11, 2025
63e1a7d
Make small updates to ChromeNotFoundError
LiamConnors Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/py/kaleido/kaleido.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,10 @@ def __init__(self, *args, **kwargs): # noqa: D417 no args/kwargs in description
super().__init__(*args, **kwargs)
except ChromeNotFoundError:
raise ChromeNotFoundError(
"Versions 1.0.0 and higher of Kaleido do not include chrome by"
"default. Earlier versions, which can be pinned, did but the strategy "
"is no longer tenable. Kaleido's supplies a kaleido_get_chrome CLI "
"command as well as a `get_chrome()` and `get_chrome_sync()` "
"functions in kaleido.",
"Kaleido v1 and later requires Chrome to be installed. "
"To install Chrome, use the CLI command `kaleido_get_chrome`, "
"or from Python, use either `kaleido.get_chrome()` "
"or `kaleido.get_chrome_sync()`.",
) from ChromeNotFoundError

if page and isinstance(page, str) and Path(page).is_file():
Expand Down