Skip to content

Correct Json mapping for Angular and Radial Axis Styles#252

Merged
kMutagene merged 3 commits intoplotly:devfrom
FlippievanDyk:dev
Dec 14, 2021
Merged

Correct Json mapping for Angular and Radial Axis Styles#252
kMutagene merged 3 commits intoplotly:devfrom
FlippievanDyk:dev

Conversation

@FlippievanDyk
Copy link
Copy Markdown
Contributor

Corrects json representation of AngularAxis styles

  • direction
    • uses setValueOptBy for Direction, to map the DU
  • rotation
  • period
  • tickVals
  • tickFormat
  • tickText

closes #251

@FlippievanDyk FlippievanDyk changed the title Corrects json representation of direction, rotation and period Correct Json mapping for Angular and Radial Axis Styles Dec 10, 2021
@FlippievanDyk
Copy link
Copy Markdown
Contributor Author

I am by no means an expert on Plotly, but it appears all the json keys are completely lower case, at least for the styles.
I think I got everything, only found issues in the Polar folder, however, it may be possible to just put a String.toLower function inline, to ensure this cannot cause a bug? The problem with that is the extra function call, so I think that is why it isn't like that already.

Wither way, I think those I have changed are trivial.

@kMutagene kMutagene merged commit ea809d1 into plotly:dev Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some AngularAxis's Layout Styles mapped incorrectly

2 participants