Skip to content

Reduce logging level for ldd failure #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilykl merged 1 commit into from
May 7, 2025
Merged

Reduce logging level for ldd failure #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion choreographer/browsers/chromium.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ def _libs_ok(self) -> bool:
except Exception as e: # noqa: BLE001
msg = "ldd failed."
stderr = p.stderr.decode() if p and p.stderr else None
_logger.warning(
# Log failure as INFO rather than WARNING so that it's hidden by default,
# since browser may succeed even if ldd fails
_logger.info(
msg # noqa: G003 + in log
+ f" e: {e}, stderr: {stderr}",
)
Expand Down