Add dynamic detailCellRendererParams support for Master/Detail detail-grid columns#455
Add dynamic detailCellRendererParams support for Master/Detail detail-grid columns#455
detailCellRendererParams support for Master/Detail detail-grid columns#455Conversation
Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/46ba3652-c128-4b3a-9f3f-5720519c2589 Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>
Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/46ba3652-c128-4b3a-9f3f-5720519c2589 Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>
detailCellRendererParams support for Master/Detail detail-grid columns
|
Add a test for this. Check the headers of the detail grid. |
There was a problem hiding this comment.
Pull request overview
Adds runtime + API + documentation support for dynamic detailCellRendererParams (function form) in Dash AG Grid Master/Detail, ensuring returned params are normalized/converted the same way as static params to avoid blank/loading detail grids when rows are expanded.
Changes:
- Updated prop conversion to allow
detailCellRendererParamsto be provided as{ function: "..." }, normalizing the returned object (includingsuppressCallbackwiring + recursivedetailGridOptionsconversion). - Expanded
detailCellRendererParamsPropTypes to accept either a static params object or{ function: string }. - Added docs + a regression test demonstrating per-row dynamic detail column definitions.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/lib/fragments/AgGrid.react.js |
Implements dynamic detailCellRendererParams handling + shared normalization/conversion of returned params. |
src/lib/components/AgGrid.react.js |
Updates PropTypes contract to allow dynamic { function: string } form. |
docs/examples/enterprise/master_detail.py |
Adds a dynamic-detail-columns example using a JS function returning per-row detail grid columnDefs. |
tests/test_recursive_functions.py |
Adds a regression test validating dynamic per-row detail grid columns in Master/Detail. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/11ea2980-aa7b-421d-96c2-6e13bf4fdce6 Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>
Added header checks to the dynamic Master/Detail regression test in commit |
|
Add changelog entry |
Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/3fa839fc-17e1-4335-ad84-edd4e27a1079 Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>
Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/8ac40ce1-2f40-4da6-be94-8b7a9896c93f Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>
Added in commit Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
Fix the failing test |
Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/87adbb38-84cf-46b5-91ce-a5370263340a Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>
Fixed in commit Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Master/Detail in Dash AG Grid documented static
detailCellRendererParams, but did not cover AG Grid’s dynamic detail-grid definitions. Users attempting to update detail params dynamically could end up with already-open detail grids stuck in a loading/blank state.Runtime support: dynamic detail params
detailCellRendererParamsas a function ({"function": "..."}) in addition to a static object.suppressCallback→getDetailRowDatawiringdetailGridOptionsrecursive conversion/component injectionProp contract update
detailCellRendererParamsPropTypes to support both:{ function: string }dynamic formDocs: dynamic columns example
Focused test coverage
detailCellRendererParamsin Master/Detail to validate per-row detail column behavior.