Skip to content

Conversation

@mkcor
Copy link
Contributor

@mkcor mkcor commented Nov 20, 2019

About

Let's use the newly released version of dash-bio-utils.

Description of changes

dash-bio will now use https://github.com/plotly/dash-bio-utils/releases/tag/v0.0.4.

Before merging

Copy link
Contributor

@shammamah-zz shammamah-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkcor I'll approve this PR, but while checking the demo apps I'm seeing some issues with the example data files you can download from within the app; in, e.g., Speck and SequenceViewer, clicking the button to download sample data downloads the HTML for the page for some reason (instead of the actual file). I'll open an issue for this too. (Edit: looks like this is only the case for when the app is being run through index.py (which the Heroku test deployment apps are running).)

@mkcor
Copy link
Contributor Author

mkcor commented Nov 20, 2019

@shammamah Good catch! Yes, the issue is present also with dash-bio-utils==0.0.3rc3, when running the demo apps through index.py... So it's independent of this change.

@mkcor mkcor merged commit 48334ac into master Nov 20, 2019
@mkcor mkcor deleted the mkcor-patch-1 branch November 20, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants