get token from callback_context#41
Merged
Merged
Conversation
michaelbabyn
approved these changes
Oct 22, 2024
Contributor
michaelbabyn
left a comment
michaelbabyn
left a comment
There was a problem hiding this comment.
This looks good to me 💃
Contributor
Author
|
I changed to have the token from the request cookies first since this is also called from other routes. Also moved the flask context check to allow the function to be called from celery. Fix https://github.com/plotly/dekn/issues/8953 @michaelbabyn Can you have a look again? Thank you. |
michaelbabyn
approved these changes
Oct 23, 2024
Contributor
michaelbabyn
left a comment
michaelbabyn
left a comment
There was a problem hiding this comment.
This works after the change to dash that I mentioned in plotly/dash#3051 💃
HammadTheOne
approved these changes
Oct 29, 2024
Member
|
@T4rk1n is this good to merge? |
Contributor
Author
Yes, just need to test it works with the latest dash version. |
Contributor
Author
|
Tested and working on de5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take the token from the callback_context added in plotly/dash#3051
Fix
get_usernamecalled inside a background callback.