Skip to content

Conversation

@alexshoe
Copy link
Contributor

@alexshoe alexshoe commented Sep 30, 2022

Component property fixes:

  • Adding the following line helps to trigger currentTime, secondsLoaded, and duration to update:
componentDidMount() {
    this.updateDuration()
}
  • Component was rebuilt and tested with all usage files, everything works as intended and expected.

Additional changes:

  • Re-adding the @plotly scope to the package, but building the package without an "@plotly" directory
  • Simplifies build command to npm run build
  • Updates DESCRIPTION file
  • Fixes description for className in source code

@alexshoe alexshoe linked an issue Sep 30, 2022 that may be closed by this pull request
@alexshoe alexshoe mentioned this pull request Oct 4, 2022
@alexshoe alexshoe requested a review from alexcjohnson October 4, 2022 18:13
@alexshoe alexshoe marked this pull request as ready for review October 4, 2022 18:13
@alexshoe alexshoe requested a review from alexcjohnson October 12, 2022 20:01
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 LGTM!

@alexshoe alexshoe merged commit 888cde0 into main Oct 17, 2022
@alexshoe alexshoe deleted the fix-property-updating branch October 17, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Callback Bug

3 participants