Skip to content

Fix typo #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LiamConnors merged 5 commits into from
Nov 4, 2022
Merged

Fix typo #57

LiamConnors merged 5 commits into from
Nov 4, 2022

Conversation

@LiamConnors
Copy link
Member

@LiamConnors LiamConnors commented Oct 25, 2022

No description provided.

@LiamConnors LiamConnors requested a review from alexshoe October 25, 2022 14:04
@alexshoe
Copy link
Contributor

alexshoe commented Nov 1, 2022

Thanks for making this fix @LiamConnors. Would you mind making sure your PR passes all the tests? I can approve as soon as that's done

@alexshoe
Copy link
Contributor

alexshoe commented Nov 1, 2022

@LiamConnors, I forgot to mention that you'll need to run npm run build in order to rebuild the package as well

@LiamConnors
Copy link
Member Author

LiamConnors commented Nov 4, 2022

Thanks @alexshoe, npm run build brought in some other changes too: https://github.com/plotly/dash-player/pull/57/files#diff-69bf43dfa1742c00789bd3a792ada573b73143461a0fd110363edfa587520572R98-R102
Would that just be because it wasn't run last time something was merged?

alexcjohnson
alexcjohnson reviewed Nov 4, 2022
View reviewed changes
alexcjohnson
alexcjohnson reviewed Nov 4, 2022
View reviewed changes
LiamConnors and others added 2 commits November 4, 2022 15:49
@LiamConnors @alexcjohnson
Update requirements-dev.txt
02d727b 
Co-authored-by: Alex Johnson <alex@plot.ly>
@LiamConnors
Update DashPlayer.py
99fa3ab
alexcjohnson
alexcjohnson approved these changes Nov 4, 2022
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@LiamConnors LiamConnors merged commit 6ccce67 into main Nov 4, 2022
@LiamConnors LiamConnors deleted the fix-typo branch November 4, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

@alexshoe alexshoe Awaiting requested review from alexshoe

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LiamConnors @alexshoe @alexcjohnson