Skip to content

Conversation

@LiamConnors
Copy link
Member

@LiamConnors LiamConnors commented Mar 6, 2023

@LiamConnors LiamConnors marked this pull request as ready for review March 7, 2023 00:32
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 after updating the manifest!

Co-authored-by: Alex Johnson <alex@plot.ly>
@alexcjohnson
Copy link
Collaborator

Oh let's add a changelog entry.

Don't need to do it in this PR unless you want to, but the one other thing we should do before publishing a new release is update deps:

> ncu
 @babel/core                                 ^7.19.1  →   ^7.21.0
 @babel/plugin-proposal-object-rest-spread   ^7.18.9  →   ^7.20.7
 @babel/preset-env                           ^7.19.1  →   ^7.20.2
 @types/node                                ^18.7.18  →  ^18.14.6
 babel-loader                                 ^8.2.5  →    ^9.1.2
 css-loader                                   ^6.7.1  →    ^6.7.3
 eslint                                      ^8.23.1  →   ^8.35.0
 eslint-config-prettier                       ^8.5.0  →    ^8.7.0
 eslint-plugin-import                        ^2.26.0  →   ^2.27.5
 eslint-plugin-react                         ^7.31.8  →   ^7.32.2
 react-player                                 2.11.0  →    2.12.0
 styled-jsx                                   ^5.0.7  →    ^5.1.2
 webpack                                     ^5.74.0  →   ^5.76.0
 webpack-cli                                 ^4.10.0  →    ^5.0.1

I don't think we actually use @types/node or styled-jsx in this project, do we? Maybe take them out, delete node_modules and reinstall, and see if it still builds?

And I would suggest we call the next release 1.1.0 since async is a fairly substantial change even if most folks won't see it as explicitly a new feature

Co-authored-by: Alex Johnson <alex@plot.ly>
@alexcjohnson alexcjohnson merged commit b1e7f65 into main Mar 9, 2023
@alexcjohnson alexcjohnson deleted the async-player branch March 9, 2023 20:53
@LiamConnors LiamConnors mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants