-
-
Notifications
You must be signed in to change notification settings - Fork 15
Make component async #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alexcjohnson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 after updating the manifest!
Co-authored-by: Alex Johnson <alex@plot.ly>
|
Oh let's add a changelog entry. Don't need to do it in this PR unless you want to, but the one other thing we should do before publishing a new release is update deps: I don't think we actually use And I would suggest we call the next release 1.1.0 since async is a fairly substantial change even if most folks won't see it as explicitly a new feature |
Co-authored-by: Alex Johnson <alex@plot.ly>
Wasn't sure @alexcjohnson , should this map.js file go in the MANIFEST https://github.com/plotly/dash-player/pull/73/files#diff-41d5a52589e0480be9c099d2bba7a8135b8b0d71bcbb8df3582a8df1c2295003R4