Conversation
shammamah-zz
left a comment
shammamah-zz
left a comment
There was a problem hiding this comment.
Please finish up the mobile layout and re-request a review!
| @@ -0,0 +1,82 @@ | |||
| # Support Vector Machine (SVM) Explorer [](https://github.com/plotly/dash-svm/blob/master/LICENSE.md) [](https://github.com/josephmisiti/awesome-machine-learning) | |||
There was a problem hiding this comment.
| # Support Vector Machine (SVM) Explorer [](https://github.com/plotly/dash-svm/blob/master/LICENSE.md) [](https://github.com/josephmisiti/awesome-machine-learning) | |
| # Support Vector Machine (SVM) Explorer [](https://github.com/josephmisiti/awesome-machine-learning) |
There was a problem hiding this comment.
@YunkeXiao You didn't actually make this change, please commit the suggestion above.
shammamah-zz
left a comment
shammamah-zz
left a comment
There was a problem hiding this comment.
I'm getting some weird errors:
The graph is also not showing up, and the mobile layout loads on desktop for some reason. Please fix these!
| @@ -1,5 +1,7 @@ | |||
| @import url('https://fonts.googleapis.com/css?family=Playfair+Display'); | |||
|
|
|||
| /* Body | |||
There was a problem hiding this comment.
You can get rid of this comment.
celinehuang
left a comment
celinehuang
left a comment
There was a problem hiding this comment.
Looks good! Super clean code 😃
|
|
||
| Clone the git repo, then install the requirements with pip | ||
| ``` | ||
| git clone https://github.com/plotly/dash-svm.git |
There was a problem hiding this comment.
please update to the new link (monorepo link)!
| Clone the git repo, then install the requirements with pip | ||
| ``` | ||
| git clone https://github.com/plotly/dash-svm.git | ||
| cd dash-svm |
There was a problem hiding this comment.
cd dash-sample-apps/apps/dash-svm
|
|
||
| /* Remove Undo | ||
| –––––––––––––––––––––––––––––––––––––––––––––––––– */ | ||
| ._dash-undo-redo { |
There was a problem hiding this comment.
remove this since the new version of Dash does this for us!
… css for the plotly tool
celinehuang
left a comment
celinehuang
left a comment
There was a problem hiding this comment.
💃 woohoo looks good!
4 participants
Issue for app: #39
App pull request
About
Workflow
elements necessary for successful deployment are in place.
existing gallery app, I've summarized the changes requested in the
appropriate Streambed issue and confirm that they have been applied.
the GitHub repository for the source code in the portal description.
DashR gallery, the app in this PR mimics, as closely as possible,
the style and functionality of the existing app.
The pre-review review
I have addressed all of the following questions:
any dead and/or irrelevant code.)
readable and, where it isn't, it has been commented appropriately.)]
lessen the volume of code that needs to be maintained.)