Conversation
|
@Mskycoder Looks like there's an application error on the playground deployment. Could you please fix that? |
shammamah-zz
left a comment
shammamah-zz
left a comment
There was a problem hiding this comment.
I can't see the playground app -- can you please make sure that the link is correct?
|
|
||
| app.layout = html.Div( | ||
| [ | ||
| # header |
There was a problem hiding this comment.
You can probably get rid of these comments!
| @@ -0,0 +1,32 @@ | |||
| certifi | |||
There was a problem hiding this comment.
Please lock all of these versions, and make sure that they are all required (I don't think all of them should be). We want to keep this file as short as possible.
| @@ -0,0 +1 @@ | |||
| web: gunicorn index:server No newline at end of file | |||
There was a problem hiding this comment.
This should also have the --pythonpath part (see the README of this repository for an example of a Procfile).
…nto dash-salesforce-crm
…sample-apps into dash-salesforce-crm
|
|
||
| ``` | ||
|
|
||
| To run the app, please create a SalesForce developer account (link is in the `About the App` section)and put the credentials in the `secrets.example.sh` file. |
There was a problem hiding this comment.
They will have to copy the file and rename it secrets.sh and run the script to export the variables. I think it's worth mentioning it.
There was a problem hiding this comment.
why would they have to rename the file to secrets.sh? The command is source secrets.example.sh to provide the login info right?
There was a problem hiding this comment.
secrets.example.sh is meant to be like a template file. If they modify that file, they might push the credentials to github. However, if they modify the secrets.sh file, it won't matter since it's .gitignore.
|
@celinehuang Could you please, in the mobile layout:
Other than that, looks good to me :) |
the mock up has it like this |
|
No need to make it full width, but please center the dropdowns! |
6 participants
Issue for app: #8
App pull request
About
Workflow
elements necessary for successful deployment are in place.
existing gallery app, I've summarized the changes requested in the
appropriate Streambed issue and confirm that they have been applied.
the GitHub repository for the source code in the portal description.
assets/folder.The pre-review review
I have addressed all of the following questions:
any dead and/or irrelevant code.)
readable and, where it isn't, it has been commented appropriately.)]
lessen the volume of code that needs to be maintained.)