Dash-datashader: update Dash version to 1.0.0#241
Merged
christopherjeon merged 11 commits intomasterfrom Jul 30, 2019
Merged
Conversation
christopherjeon
requested review from
YunkeXiao and
alinastarkov
and removed request for
alinastarkov
YunkeXiao
reviewed
Jul 23, 2019
| justify-content: space-evenly; | ||
| } | ||
|
|
||
| @media only screen and (max-width: 800px) { |
Contributor
There was a problem hiding this comment.
Why are there changes to the stylesheet?
Contributor
Author
There was a problem hiding this comment.
Yunke said he had something to fix in the mobile layout
Contributor
shammamah-zz
left a comment
shammamah-zz
left a comment
There was a problem hiding this comment.
For both layouts, let's reduce the size of the logo by about 50%. For the mobile layout, please add a larger margin at the bottom of the page that is the same size as the margin between the logo and the top of the page. Other than that, looks good :)
YunkeXiao
approved these changes
Jul 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for app: #41
App pull request
About
Workflow
elements necessary for successful deployment are in place.
existing gallery app, I've summarized the changes requested in the
appropriate Streambed issue and confirm that they have been applied.
the GitHub repository for the source code in the portal description.
assets/folder.The pre-review review
I have addressed all of the following questions:
any dead and/or irrelevant code.)
readable and, where it isn't, it has been commented appropriately.)]
lessen the volume of code that needs to be maintained.)