Conversation
New Plotly/Dash logo.
…sample-apps into change-dashbio-logo
|
|
||
|
|
||
| dividends_table <- generate_table(remove.factors(dividends_data)) | ||
| dividends_table <- generate_table(dividends_data) |
There was a problem hiding this comment.
Not sure why this diff is here -- this PR looks like it's for the Dash Bio apps. Might be a merge issue with master?
There was a problem hiding this comment.
I was just going through all apps I'd worked on to check the logo used on them and noticed this small bug. There's no real changes with the app itself, but should I open a separate PR for this?
There was a problem hiding this comment.
@HammadTheOne Is it possible to ignore this file and remove the directory from your commit (without erasing the existing app, of course)? Even if it triggers a conflict, we can resolve it before merging.
There was a problem hiding this comment.
Should be fixed now, I reverted the change from this commit. Is that OK?
Added logo.png to assets for Alignment-Viewer
rpkyle
left a comment
rpkyle
left a comment
There was a problem hiding this comment.
Thanks for fixing up the CSS font issue, and adding the logo to dashr-alignment-viewer.
I'm seeing some CSS positioning issues with Needle Plot and Speck, but those are out of scope for your PR. I think we're ready to 💃 assuming the font 404 errors are gone.
| width = '50', | ||
| style = list('top' = '10', 'margin-left' = '10px')), | ||
| children = list( | ||
| htmlImg(src='assets/plotly-dash-bio-logo.png', height = '36', width = '180', |
There was a problem hiding this comment.
@HammadTheOne Can we confirm that this file exists in assets? I don't think I see it in my local clone.
shammamah-zz
left a comment
shammamah-zz
left a comment
There was a problem hiding this comment.
💃 It looks good to me!
3 participants
Issue - Dash Bio app logo's have been updated to reflect the new Plotly - Dash logo in the python version. This PR fixes the headers and updates the logo for all Dash-Bio R app versions and adds the logo to their corresponding assets.
App pull request
Workflow
elements necessary for successful deployment are in place.
existing gallery app, I've summarized the changes requested in the
appropriate Streambed issue and confirm that they have been applied.
the GitHub repository for the source code in the portal description.
DashR gallery, the app in this PR mimics, as closely as possible,
the style and functionality of the existing app.=
assets/folder.The pre-review review
I have addressed all of the following questions:
any dead and/or irrelevant code.)
readable and, where it isn't, it has been commented appropriately.)]
lessen the volume of code that needs to be maintained.)