Skip to content

re-run CircleCI job + re-deploy on playground (Dash Brain Viewer)#283

Merged
christopherjeon merged 4 commits intomasterfrom
dash-brain-viewer
Aug 15, 2019
Merged

re-run CircleCI job + re-deploy on playground (Dash Brain Viewer)#283
christopherjeon merged 4 commits intomasterfrom
dash-brain-viewer

Conversation

@christopherjeon
Copy link
Copy Markdown
Contributor

Issue for app: #24

App pull request

  • This is a new app
  • I am improving an existing app (redesigns/code "makeovers")

About

Workflow

  • I have created a branch in the appropriate monorepo, and the
    elements necessary for successful deployment are in place.
  • If the app is a redesigned and/or restyled version of an
    existing gallery app, I've summarized the changes requested in the
    appropriate Streambed issue and confirm that they have been applied.
  • If the app is on the Dash Gallery portal, I have added a link to
    the GitHub repository for the source code in the portal description.
  • I have removed all Google Analytics code from the app's
    assets/ folder.

The pre-review review

I have addressed all of the following questions:

  • Does everything in my code serve some purpose? (I have removed
    any dead and/or irrelevant code.)
  • Does everything in my code have a clear purpose? (My code is
    readable and, where it isn't, it has been commented appropriately.)]
  • Am I reinventing the wheel? (I have used appropriate packages to
    lessen the volume of code that needs to be maintained.)

@christopherjeon christopherjeon changed the title re-run CircleCI job + re-deploy on playground (Dash Oil and Gas) re-run CircleCI job + re-deploy on playground (Dash Brain Viewer) Aug 9, 2019
Copy link
Copy Markdown
Contributor

@celinehuang celinehuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@christopherjeon christopherjeon merged commit 42e83e6 into master Aug 15, 2019
@josegonzalez josegonzalez deleted the dash-brain-viewer branch December 23, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants