Propose various improvement to circleci workflow#589
Merged
Conversation
added 5 commits
March 30, 2021 14:15
By only copying the runtime.txt when it exists, this makes it optional for deployment
Change to a log-warn instead of log-fail
ycaokris
approved these changes
Mar 31, 2021
Contributor
ycaokris
left a comment
ycaokris
left a comment
There was a problem hiding this comment.
LGTM 💃 let's merge and verify that deployment to gallery works as expected.
Author
|
@ycaokris Trying it out here: https://github.com/plotly/dash-sample-apps/tree/test-new-circleci-2 |
xhluca
pushed a commit
that referenced
this pull request
Jul 13, 2021
Propose various improvement to circleci workflow Former-commit-id: 2f8ed51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_app=truewhen deploying the gallery so we don't have to manually create the app beforehandruntime.txtoptional during deploymentassetsdirectory optional if the app does not contain any custom css or images