This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Issue 189 - Number formatting #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add formatter resolution code - use formatter in cell label - add formatting prop
added 2 commits
February 18, 2019 12:38
…able into issue189-number-formatting
- add si prefix support - update js props and code to support si prefix
added 2 commits
February 20, 2019 14:27
…able into issue189-number-formatting
| UPPER_CASE_HEX = 'X' | ||
| UNICODE = 'c' | ||
|
|
||
| class Format(): |
There was a problem hiding this comment.
A fuent interface to create the desired format/locale/prefix configuration
| self.specifier['precision'], | ||
| self.specifier['trim'].value, | ||
| self.specifier['type'].value | ||
| ) |
There was a problem hiding this comment.
Returns the actual format configuration object corresponding to all previous operations
added 2 commits
February 27, 2019 11:20
…able into issue189-number-formatting
Marc-Andre-Rivet
changed the title
@chriddyp do you have an opinion about the default |
added 2 commits
February 28, 2019 08:27
…able into issue189-number-formatting
alexcjohnson
approved these changes
Feb 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been released!
See the documentation in the new Data Types Chapter of the Dash DataTable User Guide.
(Original PR below)
This is a work in progress and not quite ready for review 😄
Fixes #189
separate_4digits nested prop under
localewill prevent grouping on values ]-10000,+10000[BI logic here means (1) data validation and (2) data sanitizing -- more data sanitizing/validation can be added in the future, for now concerning itself with columns (new) & pagination/filtering/sorting (refactored)
currencytosymboldash-docs(https://github.com/plotly/dash-docs/pull/416)Edge cases identified while writing tests or documentation
Approach: overridable
nullybehavior, non-number types are passthroughs''in those cases) and information is lostApproach Keep a duplicate of the df slice copied -- if during paste the df slice's stringification is the same as the clipboard content, assume that the data came from a datatable.
nullycase behavior (currently''(empty string)Note:
Diff settings->Hide whitespacehelps with a few of the diffs that involve indentation changes..