This repository was archived by the owner on Aug 29, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 72
Issue 189 - Number formatting #377
Merged
Merged
Changes from all commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
8534325
- add d3-format 3rd party library
a56c7d8
- update tests
b5727c3
Merge branch 'master' into issue189-number-formatting
Marc-Andre-Rivet c754615
- add locale logic and nested props
1ac8bfa
Merge branch 'issue189-number-formatting' of github.com:plotly/dash-t…
c210430
- locale support
aad2b80
- format validation that we can't do with our usage of proptypes
4f2263f
- this is js, not ts!
b537f24
incorrect usage
de4bd16
- first draft of py formatting helpers
37c5ac9
- merge format and specifier
d0a8826
Merge branch 'master' into issue189-number-formatting
Marc-Andre-Rivet a76e9cf
- table level `locale_format` prop
45ddda6
Merge branch 'issue189-number-formatting' of github.com:plotly/dash-t…
58ae65e
- document new props
64b2b75
- fix ts import resolution for tests (in IDE)
a287764
- unit tests of type/number formatter
2885238
Merge branch 'master' into issue189-number-formatting
Marc-Andre-Rivet 8ecd996
- push data table validation up the stack
c780083
Merge branch 'issue189-number-formatting' of github.com:plotly/dash-t…
df174fb
fix lint
36c9155
- isolate column sanitation (clone)
fb0d29e
- isolate d3 idiosyncracy (thousands) from API
6619066
- separate thousands nested prop, tests and defaults
6523f9c
- update changelog
dc13b4e
- formatting app mode with a few variations baked in
fc95c5f
- fix clipboard behavior when copying nully data
f33280c
- fix clipboard behavior on nully cases
d4ad094
- update py implementation for helpers
b9655e9
- kwargs (a first attempt, I'm sure)
a2b1413
Merge branch 'master' into issue189-number-formatting
Marc-Andre-Rivet 1b5b471
- remove unused imports
f5f840c
Merge branch 'issue189-number-formatting' of github.com:plotly/dash-t…
1fcc851
- default specifier / sanitation
e294ee1
make sure flake8 is present for linting job!
f9c599c
exec-sh?
88ee721
.
5c13118
.
c3c338f
.
164bde9
.
351395a
.
a4c4f51
Merge branch 'master' into issue189-number-formatting
Marc-Andre-Rivet 07bad56
- update Format class
c994ef8
Merge branch 'issue189-number-formatting' of github.com:plotly/dash-t…
7f3c222
- to_plotly_json
121dc86
- rename currency to symbol
b618183
fix lint
1938bee
- format unit tests
a2d5bab
- update templates
4c3a91a
- sanity on templates
52a4d30
- improve format templates
3956b50
- fix format tempates
fd62385
fix lint
4ab6a2c
- update py formatting tests
eb98da7
py27 fixes
f2acd4e
revert version change
ba926f1
py27 and py37 support w/ unicode check
0b24ca8
str/unicode detection without version flag
53aa524
- fix pr comments
5a2159b
Merge branch 'master' into issue189-number-formatting
Marc-Andre-Rivet fc74d02
meta
1f30b8e
Merge branch 'issue189-number-formatting' of github.com:plotly/dash-t…
e242200
Merge branch 'master' into issue189-number-formatting
Marc-Andre-Rivet 7a7c8ff
- typo
a44b733
Merge branch 'issue189-number-formatting' of github.com:plotly/dash-t…
7916b29
- fix tests
fe73302
- spellcheck
a4c6789
fix tests
29b2858
expected!
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,41 @@ | ||
| { | ||
| "tslint.jsEnable": true | ||
| "tslint.jsEnable": true, | ||
| "cSpell.allowCompoundWords": true, | ||
| "cSpell.ignorePaths": [ | ||
| "**/package.json", | ||
| "**/package-lock.json", | ||
| "**/node_modules/**", | ||
| "**/vscode-extension/**", | ||
| "**/.git/**", | ||
| ".vscode", | ||
| "typings" | ||
| ], | ||
| "cSpell.ignoreRegExpList": [ | ||
| "'" | ||
| ], | ||
| "cSpell.language": "en", | ||
| "cSpell.diagnosticLevel": "Error", | ||
| "cSpell.languageSettings": [ | ||
| { "languageId": "*", "dictionaries": ["fonts", "css", "html", "npm", "typescript", "python"]} | ||
| ], | ||
| "cSpell.words": [ | ||
| "atto", | ||
| "deletable", | ||
| "femto", | ||
| "giga", | ||
| "ints", | ||
| "milli", | ||
| "nully", | ||
| "peta", | ||
| "pico", | ||
| "plotly", | ||
| "selectable", | ||
| "tera", | ||
| "tooltips", | ||
| "uneditable", | ||
| "yocto", | ||
| "yotta", | ||
| "zepto", | ||
| "zetta" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some flake linting