This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Issue 387 - Fix filtering with float condition #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add unit tests for float case
alexcjohnson
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
💃
Please include some tests related to this in #377
Particularly I'm interested in how it will work with different grouping and decimal separators - do you use those separators in the filter string? Does the value you're parsing into a float have those separators? Do nully values get handled correctly, both when nully is a number (null effectively becomes that value) and when it's a string (null is still non-numeric)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #387