Replace deprecated asyncio.iscoroutinefunction() call with inspect.iscoroutinefunction() #3545
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonschabell
requested review from
T4rk1n,
emilykl and
ndrezn
as code owners
There was a problem hiding this comment.
Pull request overview
This PR addresses a deprecation warning by replacing asyncio.iscoroutinefunction() with inspect.iscoroutinefunction() across the codebase. The asyncio version is deprecated as of Python 3.14 and will be removed in Python 3.16.
Key changes:
- Replace all instances of
asyncio.iscoroutinefunction()withinspect.iscoroutinefunction() - Add
inspectmodule imports where needed - Remove unused
asyncioimport fromdash/_callback.py
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| dash/dash.py | Added inspect import; replaced two instances of asyncio.iscoroutinefunction() with inspect.iscoroutinefunction() |
| dash/background_callback/managers/diskcache_manager.py | Added inspect import; replaced asyncio.iscoroutinefunction() with inspect.iscoroutinefunction() |
| dash/background_callback/managers/celery_manager.py | Added inspect import; replaced asyncio.iscoroutinefunction() with inspect.iscoroutinefunction() |
| dash/_jupyter.py | Replaced asyncio.iscoroutinefunction() with inspect.iscoroutinefunction() (import likely exists elsewhere in file) |
| dash/_callback.py | Added inspect import; replaced two instances of asyncio.iscoroutinefunction() with inspect.iscoroutinefunction(); removed unused asyncio import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| break | ||
|
|
||
| if asyncio.iscoroutinefunction(kernel.do_one_iteration): | ||
| if inspect.iscoroutinefunction(kernel.do_one_iteration): |
There was a problem hiding this comment.
The inspect module is not imported in this file. Add import inspect at the top of the file to avoid a NameError at runtime.
Contributor
Author
There was a problem hiding this comment.
It's imported on line 3 😄
…coroutinefunction()
brandonschabell
force-pushed
the
feature/coroutine-deprecation
branch
from
e79e2df to
a9a173f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
asyncio.iscoutinefunction()function is deprecated and will be removed in python 3.16. This begins raising deprecation warnings in python 3.14. This PR cleans that all up.Contributor Checklist
optionals
CHANGELOG.md