Conversation
|
@Gzork please review. |
|
@BRONSOLO just wanted to check in with you re the test steps and confirm the container to test the |
|
Hey @vanastassiou the testing steps look good but additional changes are needed for this PR in the end as we're vendoring the pip version being used:
Given the change to dds-vendor in 1), the image will need to be updated within the Replicated yaml for testing as well. |
cf20f51 to
893eff3
Compare
|
@tarzzz please review. |
Hey folks - I was reading through the heroku-buildpack-python CHANGELOG tonight and came across this: heroku/heroku-buildpack-python#1007. If we're updgrading the heroku buildpack too, then maybe the way we upgrade |
|
@chriddyp Upstream does opt to use |
|
@vanastassiou Can you please add a note in https://github.com/plotly/streambed/issues/15131 about Chris' comment so that it's not lost when we merge this PR.? |
https://github.com/plotly/streambed/issues/14939
The updated
get-pip.pywas generated as follows:Tested as follows:
dds-vendorDockerfileto install newpipversiondds-vendorimage.buildpacksfile containinghttps://github.com/plotly/heroku-buildpack-python.git#update-pipexecinto Dash app container and/app/.heroku/python/bin/pip --version