Skip to content

Fix Windows path handling in save_image()#2487

Open
cpsievert wants to merge 6 commits intomasterfrom
fix-save-image-windows-paths
Open

Fix Windows path handling in save_image()#2487
cpsievert wants to merge 6 commits intomasterfrom
fix-save-image-windows-paths

Conversation

@cpsievert
Copy link
Copy Markdown
Collaborator

Summary

  • add a regression test that captures the Windows temp-path interpolation bug in the Kaleido codepath
  • stop embedding file paths directly into Python source passed to reticulate
  • apply the safer path handoff to both the Kaleido v1 and legacy codepaths

Closes #2483.

Testing

  • R -q -e "devtools::test(filter = 'kaleido')"

This comment was marked as resolved.

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

save_image not working under windows

2 participants