Skip to content

as.widget() should return htmlwidget objects untouched #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpsievert merged 2 commits into from
Feb 13, 2016
Merged

as.widget() should return htmlwidget objects untouched #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ffdea0
as.widget() should return htmlwidget objects untouched
cpsievert Feb 12, 2016
5e9264f
bump version; update news
cpsievert Feb 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: plotly
Title: Create Interactive Web Graphics via Plotly's JavaScript Graphing Library
Version: 2.4.3
Version: 2.4.4
Authors@R: c(person("Carson", "Sievert", role = c("aut", "cre"),
email = "cpsievert1@gmail.com"),
person("Chris", "Parmer", role = c("aut", "cph"),
Expand Down
4 changes: 4 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
2.4.4 -- 13 Feb 2015

as.widget() now returns htmlwidget objects untouched. See #449.

2.4.3 -- 11 Feb 2015

Ensure that we always return HTTPS links. Fixes #455
Expand Down
2 changes: 2 additions & 0 deletions R/print.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ knit_print.plotly <- function(x, options, ...) {
#' htmlwidgets::saveWidget(as.widget(p), "index.html")
#' }
#'

as.widget <- function(x, ...) {
if (inherits(x, "htmlwidget")) return(x)
p <- plotly_build(x)
# set some margin defaults if none are provided
p$layout$margin <- modifyList(
Expand Down