Skip to content

No '.embed' extension for Jupyter embedded pages #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpsievert merged 1 commit into from
May 31, 2016
Merged

No '.embed' extension for Jupyter embedded pages #613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions R/print.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ knit_print.figure <- function(x, options, ...) {
knitr::asis_output(iframe)
}

#' Embed a plotly figure as an iframe into a IPython Notebook
#' Embed a plotly figure as an iframe into a Jupyter Notebook
#' @param x a plotly object
#' @param width attribute of the iframe. If \code{NULL}, the width in
#' \code{plot_ly} is used. If that is also \code{NULL}, '100\%' is the default.
Expand All @@ -128,15 +128,16 @@ embed_notebook <- function(x, width = NULL, height = NULL,
htmlwidgets::saveWidget(as.widget(l), file = basename(file))
file
} else {
paste0(l$url, ".embed")
l$url
}
iframe <- plotly_iframe(src, width %||% l$width, height %||% l$height)
iframe <- plotly_iframe(src, width %||% l$width, height %||% l$height, url_ext = "")
get("display_html", envir = asNamespace("IRdisplay"))(iframe)
}

plotly_iframe <- function(url = "", width = NULL, height = NULL) {
plotly_iframe <- function(url = "", width = NULL, height = NULL, url_ext = ".embed") {
url <- paste0(url, url_ext)
sprintf(
'<iframe src="%s.embed" width="%s" height="%s" id="igraph" scrolling="no" seamless="seamless" frameBorder="0"> </iframe>',
'<iframe src="%s" width="%s" height="%s" id="igraph" scrolling="no" seamless="seamless" frameBorder="0"> </iframe>',
url, width %||% "100%", height %||% "400"
)
}