Add notifier boolean configuration#7730
Open
silversonicaxel wants to merge 3 commits intoplotly:masterfrom
Open
Add notifier boolean configuration#7730silversonicaxel wants to merge 3 commits intoplotly:masterfrom
silversonicaxel wants to merge 3 commits intoplotly:masterfrom
Conversation
Contributor
|
@silversonicaxel would you be able to rebase your branch such that the linting changes are all in one commit? It makes it hard to review when they're all mixed in. |
silversonicaxel
force-pushed
the
feature-notifier
branch
8 times, most recently
from
2d5a55a to
0171b04
Compare
silversonicaxel
force-pushed
the
feature-notifier
branch
from
0171b04 to
5692404
Compare
Author
|
I undid most of them, (sorry I had global linter in the IDE) But the last left, seem legit to me. And project linting was not complaining, or fixing it in its execution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to allow the configuration for displaying or not the notifiers in the top - right area of the viewport.
This is related to the issue #7729 .