Skip to content

fix: correct date axis timezone in hoveranywhere/clickanywhere events #7818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
godfengliang wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −2
Open

fix: correct date axis timezone in hoveranywhere/clickanywhere events #7818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/components/fx/hover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,10 +467,28 @@ function _hover(gd, evt, subplot, noHoverEvent, eventTarget) {
evt.pointerY = ypx + yaArray[0]._offset;

if ('xval' in evt) xvalArray = helpers.flat(subplots, evt.xval);
else xvalArray = helpers.p2c(xaArray, xpx);
else {
xvalArray = helpers.p2c(xaArray, xpx);
// p2c on date axes returns a display-time value (local-time components
// encoded as UTC ms), which differs from the true UTC coordinate used
// by data points. Correct back to true UTC so event consumers receive
// values consistent with trace data and axis range. See #7816.
for(var i = 0; i < xaArray.length; i++) {
if(xaArray[i].type === 'date' && isNumeric(xvalArray[i])) {
xvalArray[i] = xvalArray[i] + new Date(xvalArray[i]).getTimezoneOffset() * 60000;
}
}
}

if ('yval' in evt) yvalArray = helpers.flat(subplots, evt.yval);
else yvalArray = helpers.p2c(yaArray, ypx);
else {
yvalArray = helpers.p2c(yaArray, ypx);
for(var i = 0; i < yaArray.length; i++) {
if(yaArray[i].type === 'date' && isNumeric(yvalArray[i])) {
yvalArray[i] = yvalArray[i] + new Date(yvalArray[i]).getTimezoneOffset() * 60000;
}
}
}

if (!isNumeric(xvalArray[0]) || !isNumeric(yvalArray[0])) {
Lib.warn('Fx.hover failed', evt, gd);
Expand Down