Skip to content

Comments

Use np.isin instead of np.in1d to fix numpy 2.4 test compatibility#5522

Open
thunze wants to merge 1 commit intoplotly:mainfrom
thunze:numpy-2.4-is1d-removal
Open

Use np.isin instead of np.in1d to fix numpy 2.4 test compatibility#5522
thunze wants to merge 1 commit intoplotly:mainfrom
thunze:numpy-2.4-is1d-removal

Conversation

@thunze
Copy link

@thunze thunze commented Feb 23, 2026

https://numpy.org/devdocs/release/2.4.0-notes.html#removed-numpy-in1d

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the code generator and not the generated files.
  • I have added tests or modified existing tests.
  • For a new feature, I have added documentation examples (please see the doc checklist as well).
  • I have added a CHANGELOG entry if changing anything substantial.
  • For a new feature or a change in behavior, I have updated the relevant docstrings in the code.

@thunze
Copy link
Author

thunze commented Feb 23, 2026

The CI failure doesn't look related to this change.

thunze added a commit to thunze/nixpkgs that referenced this pull request Feb 23, 2026
`pytest_ignore_collect` takes only `collection_path` starting with
pytest 9 [1]. Most of the paths referenced in `plotly/conftest.py`
don't exist anymore and wouldn't be collected anyway, so we can just
remove the file.

Upstream PR: plotly/plotly.py#5522

[1] https://docs.pytest.org/en/latest/deprecations.html#py-path-local-arguments-for-hooks-replaced-with-pathlib-path
@thunze thunze mentioned this pull request Feb 24, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant