Return NotImplemented for unsupported comparisons#5547
Open
RazerM wants to merge 3 commits intoplotly:mainfrom
Open
Return NotImplemented for unsupported comparisons#5547RazerM wants to merge 3 commits intoplotly:mainfrom
RazerM wants to merge 3 commits intoplotly:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
Closes #5546
Description of change
Updated the
__eq__implementations to returnNotImplementedinstead ofFalsewhen comparing against an unsupported type. This aligns with Python's data model and allows the other operand to handle the comparison.Demo
N/A
Testing strategy
Additional information (optional)
https://docs.python.org/3.14/reference/datamodel.html#object.__eq__
Guidelines