docs: Update release, docs readme files with info, corrections#5599
Conversation
| @@ -45,6 +76,117 @@ released, or which has just been included but not yet released. | |||
| release time, so that the documentation of the feature is only deployed when | |||
| it is available in a released version of `plotly.py`. | |||
There was a problem hiding this comment.
@camdecoster I edited this section a bit for clarity, feel free to accept the below if accurate.
| it is available in a released version of `plotly.py`. | |
| ### Branching strategy | |
| - The `doc-prod` branch contains the live docs which are available on the website. As soon as a change is merged into `doc-prod`, the updated docs are deployed and made publicly available. | |
| - The `main` branch contains docs which have been written but are not ready to be released, such as for an upcoming feature in the next plotly.py release. | |
| When updating the docs, two workflows are possible: | |
| - In the case of updating the docs for an already-released feature: your changes can be deployed to the documentation website as soon as they have been merged, so you should branch off of the `doc-prod` branch and open your pull request into the `doc-prod` branch. | |
| - In the case of writing docs for a new (not-yet-released) feature: you should branch off `main` and open your pull request into `main`, so that the documentation of the feature is only deployed when it is available in a released version of `plotly.py`. The `main` branch will be merged into `doc-prod` at release time, as described below. |
| section of `RELEASE.md` for the full procedure. | ||
|
|
||
| > **Release prep:** When synchronizing `main` into `doc-prod` for a new | ||
| > release, update the `plotly==` version pin in `requirements.txt` to match |
There was a problem hiding this comment.
| > release, update the `plotly==` version pin in `requirements.txt` to match | |
| > release, update the `plotly==` version pin in `doc/requirements.txt` to match |
There was a problem hiding this comment.
I'll update it.
| --- | ||
| ``` | ||
|
|
||
| The `plotly` metadata fields are the most important to get right: |
There was a problem hiding this comment.
@camdecoster It's OK to manually edit these fields, right?
There was a problem hiding this comment.
NVM I see this is addressed in the section below, maybe state here as well for clarity though.
There was a problem hiding this comment.
I'll add a bit more to clarify this.
| The filename follows the pattern `2019-07-03-<markdown-filename-without-extension>.html`. | ||
|
|
||
| First, create an account at https://account.mapbox.com/auth/signup Once that is done, navigate to https://account.mapbox.com/ and copy your "Default public token" to the file `doc/python/.mapbox_token` | ||
| > **Why the `2019-07-03-` prefix?** The downstream `graphing-library-docs` |
There was a problem hiding this comment.
Ha, I was wondering this, thanks for adding the explanation
|
|
||
| | Event | What happens | | ||
| |-------|-------------| | ||
| | Pull request (any branch) | Tutorials are built and validated. The build artifact is uploaded but not deployed. | |
There was a problem hiding this comment.
Is this correct? I'm not totally clear what 'tutorials' refers to.
| | Pull request (any branch) | Tutorials are built and validated. The build artifact is uploaded but not deployed. | | |
| | Pull request (any branch) | Tutorials (`*.md` files) are built and validated. The build artifact is uploaded but not deployed. | |
There was a problem hiding this comment.
It is correct per build-doc.yml. Tutorials are the markdown files in doc/python. It's mentioned in at the top, but reminding folks here is fine.
emilykl
left a comment
There was a problem hiding this comment.
LGTM, thanks @camdecoster for documenting this process!
Description of change
Update release and docs README files with expanded instructions, corrections of errors/typos.
Additional information (optional)
I recently released new docs for v6.7.0 and ran into some roadblocks. These updates are an attempt to clarify some steps to make this a bit easier.
Guidelines