Changed integer based indexing to location based index #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now selects first element in series rather than 0th element - old way could cause problems when the dataframe being drawn doesn't start at index 0 and starts at a higher number. Happened to me :P
I was getting error that kwargs is undefined:
```NameError Traceback (most recent call last)
<ipython-input-173-30fb7f3aeb2e> in <module>()
9 facet_row='cut',
10 color_name='depth',
---> 11 facet_col='z'
12
13 )
/home/alishobeiri/anaconda2/lib/python2.7/site-packages/plotly/figure_factory/_facet_grid.pyc in create_facet_grid(df, x, y, facet_row, facet_col, color_name, colormap, color_is_cat, facet_row_labels, facet_col_labels, height, width, trace_type, scales, dtick_x, dtick_y, show_boxes, ggplot2, binsize, **kwargs)
867 facet_row_labels, facet_col_labels, trace_type,
868 flipped_rows, flipped_cols, show_boxes, marker_color,
--> 869 kwargs_trace, kwargs_marker
870 )
871
/home/alishobeiri/anaconda2/lib/python2.7/site-packages/plotly/figure_factory/_facet_grid.pyc in _facet_grid_color_numerical(df, x, y, facet_row, facet_col, color_name, colormap, num_of_rows, num_of_cols, facet_row_labels, facet_col_labels, trace_type, flipped_rows, flipped_cols, show_boxes, marker_color, kwargs_trace, kwargs_marker)
414 type=trace_type,
415 showlegend=False,
--> 416 **kwargs
417 )
418 fig.append_trace(trace, row_count + 1, col_count + 1)
NameError: global name 'kwargs' is not defined ```
Thought it might be because kwargs should actually be kwards_trace - not sure tho
alishobeiri
changed the title
alishobeiri
changed the title
chriddyp
reviewed
Jun 26, 2017
| show_legend = False | ||
| if color_name: | ||
| if isinstance(df[color_name][0], str) or color_is_cat: | ||
| if isinstance(df[color_name].iloc[0], str) or color_is_cat: |
There was a problem hiding this comment.
are there other places in the code where this happens?
There was a problem hiding this comment.
@alishobeiri There's a elif isinstance(df[color_name][0], Number): line a little further down the code that you can change too.
Thanks for doing this! Awesome stuff.
|
Looks good! @alishobeiri - could you add a simple test that breaks before this code was applied but is fixed after this code was applied? |
|
Error code: df starts at 2 so there is a key error thrown |
Kully
reviewed
Jun 27, 2017
| type=trace_type, | ||
| showlegend=False, | ||
| **kwargs | ||
| **kwargs_trace |
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now selects first element in series rather than 0th index item - old way could cause problems when the dataframe doesn't start at index 0 but rather starts at a higher number. Happened to me :P