feat: Add {x,y}gap parameter to heatmaps#385
Conversation
| .text(vec!["te", "xt"]) | ||
| .transpose(true) | ||
| .visible(Visible::LegendOnly) | ||
| .x_axis("x") |
There was a problem hiding this comment.
@atticus-sullivan For completeness, could you extend the test with these two setters and the expected json.
With that in place I will merge it.
There was a problem hiding this comment.
Makes sense done 👍
There was a problem hiding this comment.
Makes sense done 👍
@atticus-sullivan could you also update the expected value. You need to update the json with the two values for xgap and ygap
Next time you can also give rights on your fork to maintainers so maintainers can push fixes directly to your fork.
There was a problem hiding this comment.
Oh sorry my bad, I was really too fast on this. Now it's fixed.
You should have the right to make changes to the branch (at least the checkbox is ticked)
|
I feel almost bad asking 🙈 do you have a "release cycle"? (basically when approximately will this be part of a new release) But I don't want to pressure (especially with that other bug/thing still open ^^), I'm just curious |
No, not a release cycle, not really. Never feel bad for asking, it is a valid question. I can make a patch release after we merge this. |
|
That would be very kind (but not necessary if the other bugfix follows soon, no need to create release after release). Should I squash the commits into one before you merge, or are you fine with the current commits? |
@atticus-sullivan That would be nice. |
I did it from the web UI. Thanks for the PR fix |
|
I just made one. Try it out and let me know. |
2 participants
see #383 (comment) basically
The docs say there are parameters
{x,y}gapfor heatmap-traces. This PR adds these parameters.See the docs:
In JS they refer to the type as "number greater than or equal to 0" similar in the python docs. By experimenting with the JS version (
plotly-3.3.1.min.js) I can say that (in that version) you can also pass floats and strings. Numbers < 0 seem to be simply "truncated" to 0.Thus I chose to use the
NumOrStringtype, but I'm not 100% on whether that's correct (especially regarding negative numbers).